Do not try to render Slack Button with empty url in Signal message #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
reviewed
Dec 8, 2023
| ] | ||
| # The button URL must have at least one character. | ||
| # Otherwise, Slack will raise a Validation error. | ||
| # external_url is not a required field. If it's empty, an empty list is added, |
There was a problem hiding this comment.
Should we make it required in the UI instead, so we always have a link to a response plan for all detections?
There was a problem hiding this comment.
Sorry for the delay, we could take that approach. I was worried about introducing friction. For example, creating new detections as part of an incident.
I can make it a required field though if you feel strongly about it.
There was a problem hiding this comment.
@mvilanova Going to merge this for now -- let me know and I can go the required route instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.